mirror of
https://github.com/Buriburizaem0n/admin-frontend-domain.git
synced 2026-09-19 09:40:13 +00:00
test(e2e): fix revoke empty-list crash and password-restore CSRF cascade
Two CI-only failures surfaced against a fresh backend DB: - The revoke test read after.data.find(), but the list endpoint omits data entirely when the admin has zero tokens, throwing on undefined. Default to []. - The password-change test's restore POST hit a 403: changing the password triggers a refresh-token that re-mints the nz-csrf cookie, so the X-CSRF-Token read just before the request can be stale. A failed restore left the admin on the rotated password and cascaded into cron/fm/visibility login failures. Add csrfRequest(), which retries once on 403 after re-reading the cookie, and use it for both profile mutations. Verified 8/8 passing across repeated fresh-DB CI-mode runs. Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
This commit is contained in:
@@ -48,6 +48,29 @@ export async function csrfHeaders(page: Page): Promise<Record<string, string>> {
|
||||
return { "X-CSRF-Token": value }
|
||||
}
|
||||
|
||||
// csrfRequest issues a mutating request with the X-CSRF-Token header, retrying
|
||||
// once if the backend re-mints the nz-csrf cookie between read and send. A
|
||||
// password change triggers a refresh-token that rotates the cookie, so a single
|
||||
// read can race the new value and 403; re-reading on 403 closes that window.
|
||||
export async function csrfRequest(
|
||||
page: Page,
|
||||
method: "post" | "patch" | "delete" | "put",
|
||||
url: string,
|
||||
options: { data?: unknown; failOnStatusCode?: boolean } = {},
|
||||
): Promise<import("@playwright/test").APIResponse> {
|
||||
let resp = await page.request[method](url, {
|
||||
...options,
|
||||
headers: await csrfHeaders(page),
|
||||
})
|
||||
if (resp.status() === 403) {
|
||||
resp = await page.request[method](url, {
|
||||
...options,
|
||||
headers: await csrfHeaders(page),
|
||||
})
|
||||
}
|
||||
return resp
|
||||
}
|
||||
|
||||
export async function expectAuthenticated(page: Page) {
|
||||
const resp = await page.request.get("/api/v1/profile")
|
||||
expect(resp.status(), "profile must respond 2xx while authenticated").toBeLessThan(400)
|
||||
|
||||
Reference in New Issue
Block a user