mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 17:50:12 +00:00
fix(rpc): enforce magic ff05ff05 on IOStream init
The inline magic check expressed the *invalid* form as \`byte0 != 0xff && byte1 != 0x05 && byte2 != 0xff && byte3 == 0x05\`, relying on && to detect a four-byte mismatch. Because && short-circuits, any payload whose byte0 happened to be 0xff was treated as a valid magic even if the remaining bytes did not match — almost every random payload slipped through and only the stream-UUID layer above stood between a caller with a valid agent secret and a live IOStream session. Extract the check into isValidIOStreamMagic stated positively (all four bytes must match) so short-circuit reasoning cannot reintroduce the bug. Co-authored-by: naiba/CloudCode <hi+cloudcode@nai.ba>
This commit is contained in:
@@ -58,6 +58,20 @@ func (s *NezhaHandler) IsStreamAuthorizedForUser(streamId string, userID uint64,
|
||||
return creator == userID
|
||||
}
|
||||
|
||||
// isValidIOStreamMagic reports whether the first four bytes of an IOStream
|
||||
// init message carry the ff05ff05 marker. Previously this was inlined as
|
||||
// `byte0 != 0xff && byte1 != 0x05 && byte2 != 0xff && byte3 == 0x05` to
|
||||
// detect *invalid* payloads — but && short-circuited so any payload whose
|
||||
// byte0 happened to be 0xff slipped through. Centralising the check here and
|
||||
// stating the contract positively (all four bytes must match) eliminates the
|
||||
// short-circuit class of mistakes.
|
||||
func isValidIOStreamMagic(data []byte) bool {
|
||||
if len(data) < 4 {
|
||||
return false
|
||||
}
|
||||
return data[0] == 0xff && data[1] == 0x05 && data[2] == 0xff && data[3] == 0x05
|
||||
}
|
||||
|
||||
// StreamOwnership returns the user ID that created the stream and whether the
|
||||
// stream is still tracked. Callers must compare the returned creator against
|
||||
// the requesting user before attaching to the stream — without this the
|
||||
|
||||
Reference in New Issue
Block a user