fix(security): harden server and service deletion lifecycle (#1220)

* test: TDD regression tests for GHSA-jx78-55p5-rwv5 stream quota enforcement

* Apply remaining changes

* fix: update action SHA allowlist and test assertions to match dependabot bump

* fix: close GHSA-jx78-55p5-rwv5 incomplete fix of GHSA-qjpp-gffx-2wm9

Finding 1 (Moderate): nil-guard reporterServer in delayCheck and notifyCheck.
ServerShared has its own lock independent of serviceResponseDataStoreLock, so
m := ServerShared.GetList() taken inside the worker can return a nil entry for
the reporter if the server was concurrently deleted. Previously this caused an
unrecovered SIGSEGV in the worker goroutine (and in the gRPC layer with no
recovery interceptor), taking down the whole instance.

Finding 2 (Low): nil-guard ss.services[id] in ServiceSentinel.Delete().
A caller-supplied id that is absent from the registry caused
ss.services[id].CronJobID to panic, aborting the Delete loop and leaving every
subsequent valid id as a zombie service (DB row deleted, in-memory entry kept,
cron probe still running).

Regression tests added for both findings following the existing
servicesentinel_lifecycle_test.go patterns.

* Apply remaining changes

* chore: replace commit hashes with version tags in test.yml

* fix(server): serialize authoritative lifecycle changes

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

* fix(service): bind reports to reporter lifecycle

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

* fix(rpc): reject results from stale task streams

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

* fix(agentcompat): allow version-tagged actions

* fix(agentcompat): allow literal checkout refs

* refactor(agentcompat): remove SHA resolver policy

* test(agentcompat): remove resolver SHA fixtures

* test(agentcompat): remove mutable ref fixtures

* test(agentcompat): use tagged actions in secure fixtures

* test(agentcompat): update credential fixtures for tags

* test(agentcompat): update reusable action fixtures

* test(agentcompat): update artifact redaction fixtures

* test(agentcompat): finish artifact fixture tag migration

* test(agentcompat): update workflow validation fixtures

* test(agentcompat): update dependency workflow fixture

* ci(agentcompat): stop pinning cross-repository revisions

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: naiba <hi@nai.ba>
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>

integration/agentcompat/internal/workflowpolicy/policy_test.go

@@ -33,15 +33,42 @@ func TestPolicy_AcceptsSecureAgentWorkflow(t *testing.T) {
 	require.NoError(t, err)
 }
 
-func TestPolicy_AcceptsValidatedResolvedOtherRepositoryRef(t *testing.T) {
-	// Given
-	path := fixturePath(t, "secure-resolved-ref.yml")
+func TestPolicy_AcceptsCrossRepositoryCheckoutRefs(t *testing.T) {
+	tests := []struct {
+		name       string
+		fixture    string
+		repository workflowpolicy.Repository
+	}{
+		{name: "default branch", fixture: "cross-repository-default-ref.yml", repository: workflowpolicy.RepositoryNezha},
+		{name: "branch", fixture: "secure-agent.yml", repository: workflowpolicy.RepositoryAgent},
+		{name: "version tag", fixture: "secure-nezha.yml", repository: workflowpolicy.RepositoryNezha},
+	}
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			err := workflowpolicy.VerifyFile(fixturePath(t, test.fixture), test.repository)
+			require.NoError(t, err)
+		})
+	}
+}
 
-	// When
-	err := workflowpolicy.VerifyFile(path, workflowpolicy.RepositoryNezha)
-
-	// Then
-	require.NoError(t, err)
+func TestPolicy_RejectsInvalidCrossRepositoryCheckoutRefs(t *testing.T) {
+	tests := []struct {
+		name string
+		ref  string
+	}{
+		{name: "dynamic", ref: "${{ inputs.ref }}"},
+		{name: "non-string", ref: "false"},
+		{name: "empty", ref: "\"\""},
+		{name: "whitespace only", ref: "\"  \""},
+	}
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			workflow := "on:\n  pull_request:\nconcurrency: policy\npermissions:\n  contents: read\njobs:\n  verify:\n    runs-on: ubuntu-24.04\n    timeout-minutes: 10\n    steps:\n      - uses: actions/checkout@v7.0.1\n        with:\n          repository: nezhahq/agent\n          ref: " + test.ref + "\n          persist-credentials: false\n"
+			err := workflowpolicy.Verify([]byte(workflow), workflowpolicy.RepositoryNezha)
+			requireTypedPolicyError(t, err, workflowpolicy.RuleRepositoryNotLiteral)
+			require.ErrorContains(t, err, "checkout ref must be a nonempty literal")
+		})
+	}
 }
 
 func TestPolicy_RejectsPullRequestTarget(t *testing.T) {
@@ -104,18 +131,6 @@ func TestPolicy_RejectsNonliteralRepository(t *testing.T) {
 	assertFixtureRejected(t, rejected("nonliteral-repository.yml", workflowpolicy.RuleRepositoryNotLiteral, "literal"))
 }
 
-func TestPolicy_RejectsMutableOtherRepositoryRef(t *testing.T) {
-	assertFixtureRejected(t, rejected("mutable-other-repository-ref.yml", workflowpolicy.RuleOtherRepositoryRef, "40"))
-}
-
-func TestPolicy_RejectsUnvalidatedResolvedOtherRepositoryRef(t *testing.T) {
-	assertFixtureRejected(t, rejectionExpectation{fixture: "unvalidated-resolved-ref.yml", repository: workflowpolicy.RepositoryNezha, rule: workflowpolicy.RuleOtherRepositoryRef, diagnostic: "validated resolver"})
-}
-
-func TestPolicy_RejectsResolverVariableOverride(t *testing.T) {
-	assertFixtureRejected(t, rejectionExpectation{fixture: "resolver-variable-override.yml", repository: workflowpolicy.RepositoryNezha, rule: workflowpolicy.RuleOtherRepositoryRef, diagnostic: "validated resolver"})
-}
-
 func TestPolicy_RejectsMissingPersistCredentialsFalse(t *testing.T) {
 	assertFixtureRejected(t, rejected("missing-persist-credentials.yml", workflowpolicy.RulePersistCredentials, "persist-credentials"))
 }