fix(security): reserve dashboard hosts from NAT and re-check DDNS profile ownership at worker time

GHSA-x6fg-52vr-hj4w: NAT is a commonHandler any authenticated member can
create, and newHTTPandGRPCMux matches r.Host against NAT before dispatching
the dashboard/gRPC handlers, so a member could register the dashboard's own
host as a NAT Domain and hijack global routing. Add IsReservedDashboardHost
(InstallHost/ListenHost plus an operator-declared ReservedHosts list for
reverse-proxy deployments), reject reserved hosts on create/update, and drop
pre-planted records when building the startup cache.

GHSA-39g2-8x68-pmx8: bind-time CheckPermission let a member pre-bind a DDNS
profile ID that the victim would only create later. GetDDNSProvidersFromProfiles
now re-validates ownership by server owner UID and skips foreign-owned
profiles (UserID==0 is treated as a migration artifact, not an admin grant).

Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
This commit is contained in:
naiba
2026-05-31 02:04:35 +00:00
co-authored by cloudcode
parent e8dabf5bc6
commit d4837dfc7a
10 changed files with 390 additions and 2 deletions
+121
View File
@@ -0,0 +1,121 @@
package singleton
import (
"testing"
"github.com/nezhahq/nezha/model"
)
// newDDNSClassForTest builds a DDNSClass backed by an in-memory profile map,
// mirroring the production cache layout without touching the database.
func newDDNSClassForTest(profiles ...*model.DDNSProfile) *DDNSClass {
list := make(map[uint64]*model.DDNSProfile, len(profiles))
for _, p := range profiles {
list[p.ID] = p
}
return &DDNSClass{
class: class[uint64, *model.DDNSProfile]{
list: list,
sortedList: profiles,
},
}
}
// GHSA-39g2-8x68-pmx8: a server owned by the attacker must not be able to
// drive a DDNS update through a DDNS profile owned by another (victim) user.
// The worker-time resolution must skip foreign-owned profiles.
func TestGetDDNSProvidersSkipsForeignOwnedProfile(t *testing.T) {
replaceUserInfoMapForSecurityTest(t, map[uint64]model.UserInfo{
100: {Role: model.RoleMember}, // attacker / server owner
200: {Role: model.RoleMember}, // victim / profile owner
})
victimProfile := &model.DDNSProfile{
Common: model.Common{ID: 1, UserID: 200},
Provider: model.ProviderDummy,
Name: "victim-profile",
AccessSecret: "victim-secret",
}
dc := newDDNSClassForTest(victimProfile)
providers, err := dc.GetDDNSProvidersFromProfiles([]uint64{1}, &model.IP{}, 100)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if len(providers) != 0 {
t.Fatalf("expected foreign-owned profile to be skipped, got %d provider(s)", len(providers))
}
}
// A server owner using their own DDNS profile must still resolve normally.
func TestGetDDNSProvidersAllowsOwnedProfile(t *testing.T) {
replaceUserInfoMapForSecurityTest(t, map[uint64]model.UserInfo{
100: {Role: model.RoleMember},
})
ownProfile := &model.DDNSProfile{
Common: model.Common{ID: 5, UserID: 100},
Provider: model.ProviderDummy,
Name: "own-profile",
}
dc := newDDNSClassForTest(ownProfile)
providers, err := dc.GetDDNSProvidersFromProfiles([]uint64{5}, &model.IP{}, 100)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if len(providers) != 1 {
t.Fatalf("expected owned profile to resolve, got %d provider(s)", len(providers))
}
}
// An admin-owned profile may be shared across servers (admin resources are
// global), so an admin profile resolves regardless of the server owner.
func TestGetDDNSProvidersAllowsAdminOwnedProfile(t *testing.T) {
replaceUserInfoMapForSecurityTest(t, map[uint64]model.UserInfo{
1: {Role: model.RoleAdmin}, // admin / profile owner
100: {Role: model.RoleMember},
})
adminProfile := &model.DDNSProfile{
Common: model.Common{ID: 9, UserID: 1},
Provider: model.ProviderDummy,
Name: "admin-profile",
}
dc := newDDNSClassForTest(adminProfile)
providers, err := dc.GetDDNSProvidersFromProfiles([]uint64{9}, &model.IP{}, 100)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if len(providers) != 1 {
t.Fatalf("expected admin-owned profile to resolve, got %d provider(s)", len(providers))
}
}
// GHSA-39g2-8x68-pmx8 (UserID==0 variant): userIsAdmin(0) returns true as a
// "system resource" shortcut, but a DDNS profile with UserID==0 is not a real
// admin grant — it is a migration/default-value artifact. A foreign server
// owner must NOT be able to drive an update through such a profile, so the
// worker must skip a UserID==0 profile that the caller does not own.
func TestGetDDNSProvidersSkipsUnownedZeroUserProfile(t *testing.T) {
replaceUserInfoMapForSecurityTest(t, map[uint64]model.UserInfo{
100: {Role: model.RoleMember}, // attacker / server owner
})
orphanProfile := &model.DDNSProfile{
Common: model.Common{ID: 3, UserID: 0},
Provider: model.ProviderDummy,
Name: "orphan-profile",
AccessSecret: "orphan-secret",
}
dc := newDDNSClassForTest(orphanProfile)
providers, err := dc.GetDDNSProvidersFromProfiles([]uint64{3}, &model.IP{}, 100)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if len(providers) != 0 {
t.Fatalf("expected UserID==0 foreign profile to be skipped, got %d provider(s)", len(providers))
}
}