mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 09:40:12 +00:00
feat(auth): add PAT auth, scoped REST/MCP access, CSRF, and tenant isolation
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.
Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.
Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.
Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.
Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
This commit is contained in:
@@ -0,0 +1,71 @@
|
||||
package controller
|
||||
|
||||
import (
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"testing"
|
||||
|
||||
"github.com/gin-gonic/gin"
|
||||
"github.com/stretchr/testify/require"
|
||||
|
||||
"github.com/nezhahq/nezha/model"
|
||||
)
|
||||
|
||||
func setupOptionalAuthRouter(t *testing.T, plainToken string) *httptest.Server {
|
||||
t.Helper()
|
||||
gin.SetMode(gin.TestMode)
|
||||
r := gin.New()
|
||||
|
||||
jwtMw := func(c *gin.Context) {
|
||||
c.AbortWithStatusJSON(http.StatusUnauthorized, gin.H{"error": "no jwt"})
|
||||
}
|
||||
patMw := apiTokenAuthMiddleware()
|
||||
authMw := jwtOrPATAuthMiddleware(patMw, jwtMw)
|
||||
|
||||
stub := func(c *gin.Context) { c.JSON(200, gin.H{"ok": true}) }
|
||||
optionalAuth := r.Group("/api/v1", authMw)
|
||||
optionalAuth.GET("/server-group", restScopeMiddleware(model.ScopeServerRead), stub)
|
||||
optionalAuth.GET("/service", restScopeMiddleware(model.ScopeServiceRead), stub)
|
||||
optionalAuth.GET("/server/:id/metrics", restScopeMiddleware(model.ScopeServerRead), stub)
|
||||
|
||||
ts := httptest.NewServer(r)
|
||||
t.Cleanup(ts.Close)
|
||||
_ = plainToken
|
||||
return ts
|
||||
}
|
||||
|
||||
func TestOptionalAuth_PATWithoutScopeIsDenied(t *testing.T) {
|
||||
cleanup, uid := setupMCPTest(t)
|
||||
defer cleanup()
|
||||
|
||||
_, plain := mkToken(t, uid, []string{model.ScopeNotificationRead}, nil)
|
||||
ts := setupOptionalAuthRouter(t, plain)
|
||||
|
||||
for _, path := range []string{
|
||||
"/api/v1/server-group",
|
||||
"/api/v1/service",
|
||||
"/api/v1/server/7/metrics",
|
||||
} {
|
||||
resp := doReq(t, ts, "GET", path, plain)
|
||||
resp.Body.Close()
|
||||
require.Equal(t, http.StatusForbidden, resp.StatusCode, "PAT lacking required scope must be denied for %s", path)
|
||||
}
|
||||
}
|
||||
|
||||
func TestOptionalAuth_PATWithMatchingScopeAllowed(t *testing.T) {
|
||||
cleanup, uid := setupMCPTest(t)
|
||||
defer cleanup()
|
||||
|
||||
_, plain := mkToken(t, uid, []string{model.ScopeServerRead, model.ScopeServiceRead}, nil)
|
||||
ts := setupOptionalAuthRouter(t, plain)
|
||||
|
||||
for _, path := range []string{
|
||||
"/api/v1/server-group",
|
||||
"/api/v1/service",
|
||||
"/api/v1/server/7/metrics",
|
||||
} {
|
||||
resp := doReq(t, ts, "GET", path, plain)
|
||||
resp.Body.Close()
|
||||
require.Equal(t, http.StatusOK, resp.StatusCode, "PAT with matching scope must pass for %s", path)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user