mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 09:40:12 +00:00
feat(auth): add PAT auth, scoped REST/MCP access, CSRF, and tenant isolation
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.
Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.
Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.
Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.
Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
This commit is contained in:
@@ -2,7 +2,6 @@ package controller
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"maps"
|
||||
"slices"
|
||||
"strconv"
|
||||
"strings"
|
||||
@@ -56,7 +55,18 @@ func serviceResponseCacheKey(c *gin.Context) string {
|
||||
if !ok || user == nil {
|
||||
return "list-service::guest"
|
||||
}
|
||||
return fmt.Sprintf("list-service::%t::%d", user.Role.IsAdmin(), user.ID)
|
||||
base := fmt.Sprintf("list-service::%t::%d", user.Role.IsAdmin(), user.ID)
|
||||
tok := APITokenFromContext(c)
|
||||
if tok == nil {
|
||||
return base + "::jwt"
|
||||
}
|
||||
ids := tok.ServerIDs()
|
||||
slices.Sort(ids)
|
||||
parts := make([]string, 0, len(ids))
|
||||
for _, id := range ids {
|
||||
parts = append(parts, strconv.FormatUint(id, 10))
|
||||
}
|
||||
return fmt.Sprintf("%s::pat:%d::servers:%s", base, tok.ID, strings.Join(parts, ","))
|
||||
}
|
||||
|
||||
func filterCycleTransferStatsForViewer(c *gin.Context, stats map[uint64]model.CycleTransferStats) map[uint64]model.CycleTransferStats {
|
||||
@@ -459,6 +469,10 @@ func createService(c *gin.Context) (uint64, error) {
|
||||
return 0, err
|
||||
}
|
||||
|
||||
if !isValidServiceCover(mf.Cover) {
|
||||
return 0, singleton.Localizer.ErrorT("permission denied")
|
||||
}
|
||||
|
||||
uid := getUid(c)
|
||||
|
||||
var m model.Service
|
||||
@@ -518,6 +532,11 @@ func updateService(c *gin.Context) (any, error) {
|
||||
if err := c.ShouldBindJSON(&mf); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
if !isValidServiceCover(mf.Cover) {
|
||||
return nil, singleton.Localizer.ErrorT("permission denied")
|
||||
}
|
||||
|
||||
var m model.Service
|
||||
if err := singleton.DB.First(&m, id).Error; err != nil {
|
||||
return nil, singleton.Localizer.ErrorT("service id %d does not exist", id)
|
||||
@@ -581,6 +600,19 @@ func batchDeleteService(c *gin.Context) (any, error) {
|
||||
return nil, singleton.Localizer.ErrorT("permission denied")
|
||||
}
|
||||
|
||||
// 与 batchDeleteCron 对称:DispatchTask 没有 PAT 上下文,这里是阻止
|
||||
// 受限 PAT 通过删除 ServiceCoverAll + 不充分 SkipServers 间接影响
|
||||
// 白名单外 owner servers 探测状态的唯一同步入口。
|
||||
for _, id := range ids {
|
||||
existing, ok := singleton.ServiceSentinelShared.Get(id)
|
||||
if !ok || existing == nil {
|
||||
continue
|
||||
}
|
||||
if err := enforcePATServiceDispatchScope(c, existing); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
}
|
||||
|
||||
err := singleton.DB.Transaction(func(tx *gorm.DB) error {
|
||||
return tx.Unscoped().Delete(&model.Service{}, "id in (?)", ids).Error
|
||||
})
|
||||
@@ -593,8 +625,12 @@ func batchDeleteService(c *gin.Context) (any, error) {
|
||||
}
|
||||
|
||||
func validateServers(c *gin.Context, ss *model.Service) error {
|
||||
if !singleton.ServerShared.CheckPermission(c, maps.Keys(ss.SkipServers)) {
|
||||
return singleton.Localizer.ErrorT("permission denied")
|
||||
if err := checkServiceSkipServerPermission(c, ss.Cover, ss.SkipServers, ss.GetUserID()); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if err := rejectImplicitServiceCoverForLimitedPAT(c, ss.Cover, ss.SkipServers, ss.GetUserID()); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if !singleton.CronShared.CheckPermission(c, slices.Values(ss.FailTriggerTasks)) {
|
||||
@@ -603,6 +639,9 @@ func validateServers(c *gin.Context, ss *model.Service) error {
|
||||
if !singleton.CronShared.CheckPermission(c, slices.Values(ss.RecoverTriggerTasks)) {
|
||||
return singleton.Localizer.ErrorT("permission denied")
|
||||
}
|
||||
if err := enforcePATTriggerTaskScope(c, ss.FailTriggerTasks, ss.RecoverTriggerTasks); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if err := assertOwnsNotificationGroup(c, ss.NotificationGroupID); err != nil {
|
||||
return err
|
||||
|
||||
Reference in New Issue
Block a user