Files
nezha_domains/cmd/dashboard/controller/cron_cover_validation_test.go
naibaandcloudcode e8dabf5bc6 feat(auth): add PAT auth, scoped REST/MCP access, CSRF, and tenant isolation
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.

Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.

Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.

Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.

Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
2026-05-30 15:56:44 +00:00

55 lines
1.5 KiB
Go

package controller
import (
"testing"
"github.com/nezhahq/nezha/model"
)
// C2 regression: writes must reject unknown Cover values so dirty configs
// cannot be persisted. CronTrigger has no PAT context on the periodic
// scheduler path, so unknown Cover sails past every PAT guard and dispatches
// via the default branch in CronTrigger (no CoverAll/IgnoreAll match → still
// reaches every server that passes cronCanSendToServer).
func TestIsValidCronCover_RejectsUnknown(t *testing.T) {
cases := []struct {
name string
cover uint8
want bool
}{
{"CoverIgnoreAll", model.CronCoverIgnoreAll, true},
{"CoverAll", model.CronCoverAll, true},
{"CoverAlertTrigger", model.CronCoverAlertTrigger, true},
{"unknown_99", 99, false},
{"unknown_max", 255, false},
{"unknown_3", 3, false},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
if got := isValidCronCover(tc.cover); got != tc.want {
t.Fatalf("isValidCronCover(%d) = %v, want %v", tc.cover, got, tc.want)
}
})
}
}
func TestIsValidServiceCover_RejectsUnknown(t *testing.T) {
cases := []struct {
name string
cover uint8
want bool
}{
{"ServiceCoverAll", model.ServiceCoverAll, true},
{"ServiceCoverIgnoreAll", model.ServiceCoverIgnoreAll, true},
{"unknown_99", 99, false},
{"unknown_max", 255, false},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
if got := isValidServiceCover(tc.cover); got != tc.want {
t.Fatalf("isValidServiceCover(%d) = %v, want %v", tc.cover, got, tc.want)
}
})
}
}