mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 09:40:12 +00:00
naibaandcloudcode
e8dabf5bc6
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.
Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.
Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.
Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.
Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
110 lines
4.0 KiB
Go
110 lines
4.0 KiB
Go
package controller
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/nezhahq/nezha/model"
|
|
"github.com/nezhahq/nezha/service/singleton"
|
|
)
|
|
|
|
func setupMCPOriginRouter(t *testing.T) (*httptest.Server, string, func()) {
|
|
t.Helper()
|
|
cleanup, uid := setupMCPTest(t)
|
|
_, plain := mkToken(t, uid, []string{model.ScopeServerRead}, nil)
|
|
|
|
gin.SetMode(gin.TestMode)
|
|
r := gin.New()
|
|
r.POST("/mcp", mcpOriginGuard(), apiTokenAuthMiddleware(), mcpEndpoint)
|
|
r.GET("/mcp/download/:token", mcpOriginGuard(), transferDownloadHandler)
|
|
r.POST("/mcp/upload/:token", mcpOriginGuard(), transferUploadHandler)
|
|
ts := httptest.NewServer(r)
|
|
return ts, plain, func() {
|
|
ts.Close()
|
|
cleanup()
|
|
}
|
|
}
|
|
|
|
func TestMCP_DisallowsCrossOriginRequest(t *testing.T) {
|
|
ts, tok, cleanup := setupMCPOriginRouter(t)
|
|
defer cleanup()
|
|
|
|
req, _ := http.NewRequest("POST", ts.URL+"/mcp", bytes.NewReader([]byte(`{"jsonrpc":"2.0","id":1,"method":"initialize"}`)))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
req.Header.Set("Authorization", "Bearer "+tok)
|
|
req.Header.Set("Origin", "http://evil.example.com")
|
|
resp, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
defer resp.Body.Close()
|
|
require.Equal(t, http.StatusForbidden, resp.StatusCode)
|
|
}
|
|
|
|
func TestMCP_AllowsRequestWithoutOriginHeader(t *testing.T) {
|
|
ts, tok, cleanup := setupMCPOriginRouter(t)
|
|
defer cleanup()
|
|
|
|
req, _ := http.NewRequest("POST", ts.URL+"/mcp", bytes.NewReader([]byte(`{"jsonrpc":"2.0","id":1,"method":"initialize"}`)))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
req.Header.Set("Authorization", "Bearer "+tok)
|
|
resp, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
defer resp.Body.Close()
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
}
|
|
|
|
func TestMCP_AllowsSameHostOrigin(t *testing.T) {
|
|
ts, tok, cleanup := setupMCPOriginRouter(t)
|
|
defer cleanup()
|
|
|
|
req, _ := http.NewRequest("POST", ts.URL+"/mcp", bytes.NewReader([]byte(`{"jsonrpc":"2.0","id":1,"method":"initialize"}`)))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
req.Header.Set("Authorization", "Bearer "+tok)
|
|
req.Header.Set("Origin", "http://"+req.Host)
|
|
resp, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
defer resp.Body.Close()
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
}
|
|
|
|
// 公网部署回归：ListenHost 是 0.0.0.0/未指定时，前端会以公网 Host 同源访问。
|
|
// 这条以前会被 dashboardListensOnLoopback 误判为 loopback 部署进而拒掉；
|
|
// 现在必须放行，否则正常生产环境的 admin frontend MCP 入口直接 403。
|
|
func TestMCP_PublicDeployment_AllowsPublicSameOrigin(t *testing.T) {
|
|
ts, tok, cleanup := setupMCPOriginRouter(t)
|
|
defer cleanup()
|
|
|
|
req, _ := http.NewRequest("POST", ts.URL+"/mcp", bytes.NewReader([]byte(`{"jsonrpc":"2.0","id":1,"method":"initialize"}`)))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
req.Header.Set("Authorization", "Bearer "+tok)
|
|
req.Host = "dashboard.example.com"
|
|
req.Header.Set("Origin", "https://dashboard.example.com")
|
|
resp, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
defer resp.Body.Close()
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
}
|
|
|
|
// 显式绑 loopback 时仍然要执行 DNS rebinding 防线：Host 是公网域名 → 403。
|
|
func TestMCP_LoopbackDeployment_RejectsPublicHost(t *testing.T) {
|
|
ts, tok, cleanup := setupMCPOriginRouter(t)
|
|
defer cleanup()
|
|
prev := singleton.Conf.ListenHost
|
|
singleton.Conf.ListenHost = "127.0.0.1"
|
|
defer func() { singleton.Conf.ListenHost = prev }()
|
|
|
|
req, _ := http.NewRequest("POST", ts.URL+"/mcp", bytes.NewReader([]byte(`{"jsonrpc":"2.0","id":1,"method":"initialize"}`)))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
req.Header.Set("Authorization", "Bearer "+tok)
|
|
req.Host = "dashboard.example.com"
|
|
req.Header.Set("Origin", "https://dashboard.example.com")
|
|
resp, err := http.DefaultClient.Do(req)
|
|
require.NoError(t, err)
|
|
defer resp.Body.Close()
|
|
require.Equal(t, http.StatusForbidden, resp.StatusCode)
|
|
}
|