mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 09:40:12 +00:00
naibaandcloudcode
e8dabf5bc6
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.
Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.
Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.
Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.
Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
36 lines
1.3 KiB
Go
36 lines
1.3 KiB
Go
package rpc
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/nezhahq/nezha/model"
|
|
)
|
|
|
|
// H9 regression: CallAgent must consult mcpKillSwitchObserved before any
|
|
// side-effects. Without this gate, mcpEndpoint's EnableMCP read and
|
|
// CancelAllMCPInflight race against a fresh CallAgent that registers
|
|
// AFTER the cancel sweep, surviving the disabled state.
|
|
func TestCallAgent_RefusesWhenKillSwitchObserved(t *testing.T) {
|
|
prevCheck := mcpKillSwitchObserver()
|
|
SetMCPKillSwitchObserver(func() bool { return true })
|
|
t.Cleanup(func() { SetMCPKillSwitchObserver(prevCheck) })
|
|
|
|
_, err := CallAgent(context.Background(), 1, model.TaskTypeExec, struct{}{}, 50*time.Millisecond)
|
|
if err != ErrMCPDisabled {
|
|
t.Fatalf("CallAgent must short-circuit to ErrMCPDisabled when kill switch is observed, got %v", err)
|
|
}
|
|
}
|
|
|
|
// The default hook must keep production behaviour disarmed so tests and
|
|
// unconfigured deployments do not short-circuit CallAgent.
|
|
func TestCallAgent_KillSwitchHookDefaultsToDisarmed(t *testing.T) {
|
|
if mcpKillSwitchObserver() == nil {
|
|
t.Fatal("mcpKillSwitchObserver must always return a non-nil probe so dashboard can wire it")
|
|
}
|
|
if mcpKillSwitchObserver()() {
|
|
t.Fatal("default hook must return false so unconfigured dashboards / tests don't accidentally short-circuit CallAgent")
|
|
}
|
|
}
|