mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 09:40:12 +00:00
Auth.Check resolved client_uuid → server.ID via UUIDToID without checking that the resolved server's UserID matched the user that the secret was bound to. An agent presenting one user's secret could target a different user's server UUID and impersonate it — poisoning monitoring state, triggering alerts, or quietly receiving tasks the real owner expected. Add authorizeAgentForUUID: if the UUID is unknown we still allow new registration bound to the secret owner; if the UUID is known but points to someone else's server we reject. The rejection message "client UUID does not belong to the agent secret owner" also helps operators trace which user's secret has leaked. Note: this changes runtime behaviour after batch-move/server — the new owner must reconfigure agents with their own secret. That is the correct contract; the previous behaviour was a cross-user reporting bug. Co-authored-by: naiba/CloudCode <hi+cloudcode@nai.ba>
109 lines
3.2 KiB
Go
109 lines
3.2 KiB
Go
package rpc
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
petname "github.com/dustinkirkland/golang-petname"
|
|
"github.com/hashicorp/go-uuid"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/metadata"
|
|
"google.golang.org/grpc/status"
|
|
|
|
"github.com/nezhahq/nezha/model"
|
|
"github.com/nezhahq/nezha/service/singleton"
|
|
)
|
|
|
|
type authHandler struct {
|
|
ClientSecret string
|
|
ClientUUID string
|
|
}
|
|
|
|
func (a *authHandler) Check(ctx context.Context) (uint64, error) {
|
|
md, ok := metadata.FromIncomingContext(ctx)
|
|
if !ok {
|
|
return 0, status.Errorf(codes.Unauthenticated, "获取 metaData 失败")
|
|
}
|
|
|
|
var clientSecret string
|
|
if value, ok := md["client_secret"]; ok {
|
|
clientSecret = strings.TrimSpace(value[0])
|
|
}
|
|
|
|
if clientSecret == "" {
|
|
return 0, status.Error(codes.Unauthenticated, "客户端认证失败")
|
|
}
|
|
|
|
ip, _ := ctx.Value(model.CtxKeyRealIP{}).(string)
|
|
|
|
singleton.UserLock.RLock()
|
|
userId, ok := singleton.AgentSecretToUserId[clientSecret]
|
|
if !ok {
|
|
singleton.UserLock.RUnlock()
|
|
model.BlockIP(singleton.DB, ip, model.WAFBlockReasonTypeAgentAuthFail, model.BlockIDgRPC)
|
|
return 0, status.Error(codes.Unauthenticated, "客户端认证失败")
|
|
}
|
|
singleton.UserLock.RUnlock()
|
|
|
|
model.UnblockIP(singleton.DB, ip, model.BlockIDgRPC)
|
|
|
|
var clientUUID string
|
|
if value, ok := md["client_uuid"]; ok {
|
|
clientUUID = value[0]
|
|
}
|
|
|
|
if _, err := uuid.ParseUUID(clientUUID); err != nil {
|
|
return 0, status.Error(codes.Unauthenticated, "客户端 UUID 不合法")
|
|
}
|
|
|
|
clientID, hasID, err := authorizeAgentForUUID(userId, clientUUID)
|
|
if err != nil {
|
|
return 0, status.Error(codes.Unauthenticated, err.Error())
|
|
}
|
|
if !hasID {
|
|
s := model.Server{UUID: clientUUID, Name: petname.Generate(2, "-"), Common: model.Common{
|
|
UserID: userId,
|
|
}}
|
|
if err := singleton.DB.Create(&s).Error; err != nil {
|
|
return 0, status.Error(codes.Unauthenticated, err.Error())
|
|
}
|
|
|
|
model.InitServer(&s)
|
|
singleton.ServerShared.Update(&s, clientUUID)
|
|
|
|
clientID = s.ID
|
|
}
|
|
|
|
return clientID, nil
|
|
}
|
|
|
|
// authorizeAgentForUUID resolves a client UUID to the dashboard's internal
|
|
// server ID, ensuring the resolved server is actually owned by the agent
|
|
// secret's owner. Previously Check returned the resolved server ID without
|
|
// verifying ownership, allowing an agent that knew another user's server
|
|
// UUID to impersonate it (poisoning monitoring state, triggering alerts).
|
|
// hasID=false means the UUID is unknown and the caller may register it as
|
|
// a new server for the secret owner.
|
|
//
|
|
// The error path also doubles as a leak-detection signal for operators: if
|
|
// an agent persistently fails with "client UUID does not belong to the
|
|
// agent secret owner", it pins down which user's secret has been reused
|
|
// against a server they don't own.
|
|
func authorizeAgentForUUID(userId uint64, clientUUID string) (clientID uint64, hasID bool, err error) {
|
|
cid, found := singleton.ServerShared.UUIDToID(clientUUID)
|
|
if !found {
|
|
return 0, false, nil
|
|
}
|
|
server, _ := singleton.ServerShared.Get(cid)
|
|
if server == nil {
|
|
// Cache inconsistency: UUID maps to an ID, but no server record exists.
|
|
// Treat as unknown (registration path) rather than impersonation.
|
|
return 0, false, nil
|
|
}
|
|
if server.UserID != userId {
|
|
return 0, false, fmt.Errorf("client UUID does not belong to the agent secret owner")
|
|
}
|
|
return cid, true, nil
|
|
}
|