mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 09:40:12 +00:00
naibaandcloudcode
a4f4cb1f34
GET /api/v1/file?id=<server> created an FM stream on the agent stream and committed real state change (TaskTypeFM dispatched). With JWT cookie SameSite=Lax a victim's browser would still send the cookie on a top-level cross-site GET, so an attacker could trick a logged-in user into opening an FM session on any of their own servers, consuming resources and triggering the agent's FM machinery without consent. Mirror the GHSA-8qhj-4f8c-j8qg fix: move the route to POST. SameSite= Lax cookies are not sent on cross-site POST. Frontend (admin-frontend) adjusted in a follow-up commit. Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
117 lines
3.0 KiB
Go
117 lines
3.0 KiB
Go
package controller
|
|
|
|
import (
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/goccy/go-json"
|
|
"github.com/gorilla/websocket"
|
|
"github.com/hashicorp/go-uuid"
|
|
|
|
"github.com/nezhahq/nezha/model"
|
|
"github.com/nezhahq/nezha/pkg/websocketx"
|
|
"github.com/nezhahq/nezha/proto"
|
|
"github.com/nezhahq/nezha/service/rpc"
|
|
"github.com/nezhahq/nezha/service/singleton"
|
|
)
|
|
|
|
// Create FM session
|
|
// @Summary Create FM session
|
|
// @Description Create an "attached" FM. It is advised to only call this within a terminal session.
|
|
// @Tags auth required
|
|
// @Accept json
|
|
// @Param id query uint true "Server ID"
|
|
// @Produce json
|
|
// @Success 200 {object} model.CreateFMResponse
|
|
// @Router /file [post]
|
|
func createFM(c *gin.Context) (*model.CreateFMResponse, error) {
|
|
idStr := c.Query("id")
|
|
id, err := strconv.ParseUint(idStr, 10, 64)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
server, _ := singleton.ServerShared.Get(id)
|
|
if server == nil {
|
|
return nil, singleton.Localizer.ErrorT("server not found or not connected")
|
|
}
|
|
stream := server.GetTaskStream()
|
|
if stream == nil {
|
|
return nil, singleton.Localizer.ErrorT("server not found or not connected")
|
|
}
|
|
|
|
if !server.HasPermission(c) {
|
|
return nil, singleton.Localizer.ErrorT("permission denied")
|
|
}
|
|
|
|
streamId, err := uuid.GenerateUUID()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
rpc.NezhaHandlerSingleton.CreateStream(streamId, getUid(c), server.ID)
|
|
|
|
fmData, _ := json.Marshal(&model.TaskFM{
|
|
StreamID: streamId,
|
|
})
|
|
if err := stream.Send(&proto.Task{
|
|
Type: model.TaskTypeFM,
|
|
Data: string(fmData),
|
|
}); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &model.CreateFMResponse{
|
|
SessionID: streamId,
|
|
}, nil
|
|
}
|
|
|
|
// Start FM stream
|
|
// @Summary Start FM stream
|
|
// @Description Start FM stream
|
|
// @Tags auth required
|
|
// @Param id path string true "Stream UUID"
|
|
// @Success 200 {object} model.CommonResponse[any]
|
|
// @Router /ws/file/{id} [get]
|
|
func fmStream(c *gin.Context) (any, error) {
|
|
streamId := c.Param("id")
|
|
// GHSA-style fix: io_stream sessions must be reachable only by their creator
|
|
// (or an admin). Without this, any authenticated user who learns a stream
|
|
// UUID can hijack a live file-manager session on the target server.
|
|
if !rpc.NezhaHandlerSingleton.IsStreamAuthorizedForUser(streamId, getUid(c), callerIsAdmin(c)) {
|
|
return nil, singleton.Localizer.ErrorT("permission denied")
|
|
}
|
|
if _, err := rpc.NezhaHandlerSingleton.GetStream(streamId); err != nil {
|
|
return nil, err
|
|
}
|
|
defer rpc.NezhaHandlerSingleton.CloseStream(streamId)
|
|
|
|
wsConn, err := upgrader.Upgrade(c.Writer, c.Request, nil)
|
|
if err != nil {
|
|
return nil, newWsError("%v", err)
|
|
}
|
|
defer wsConn.Close()
|
|
conn := websocketx.NewConn(wsConn)
|
|
|
|
go func() {
|
|
// PING 保活
|
|
for {
|
|
if err = conn.WriteMessage(websocket.PingMessage, []byte{}); err != nil {
|
|
return
|
|
}
|
|
time.Sleep(time.Second * 10)
|
|
}
|
|
}()
|
|
|
|
if err = rpc.NezhaHandlerSingleton.UserConnected(streamId, conn); err != nil {
|
|
return nil, newWsError("%v", err)
|
|
}
|
|
|
|
if err = rpc.NezhaHandlerSingleton.StartStream(streamId, time.Second*10); err != nil {
|
|
return nil, newWsError("%v", err)
|
|
}
|
|
|
|
return nil, newWsError("")
|
|
}
|