mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 17:50:12 +00:00
naibaandcloudcode
ab25662ddd
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.
Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.
Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.
Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.
Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
114 lines
3.5 KiB
Go
114 lines
3.5 KiB
Go
package controller
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/nezhahq/nezha/model"
|
|
"github.com/nezhahq/nezha/service/singleton"
|
|
)
|
|
|
|
func TestServerList_FiltersByPermission(t *testing.T) {
|
|
cleanup, uid := setupMCPTest(t)
|
|
defer cleanup()
|
|
|
|
srv2 := &model.Server{}
|
|
srv2.ID = 8
|
|
srv2.Name = "beta"
|
|
srv2.SetUserID(999)
|
|
singleton.ServerShared.InsertForTest(srv2)
|
|
|
|
tok, _ := mkToken(t, uid, []string{model.ScopeServerRead}, nil)
|
|
c, w := mcpCallCtx(t, tok, uid, jsonRPCRequest{
|
|
JSONRPC: "2.0", ID: json.RawMessage("1"), Method: "tools/call",
|
|
Params: jsonObj(t, toolCallParams{Name: "server.list", Arguments: json.RawMessage("{}")}),
|
|
})
|
|
mcpEndpoint(c)
|
|
_, tcr := decodeRPC(w)
|
|
require.False(t, tcr.IsError)
|
|
|
|
rb, _ := json.Marshal(tcr.StructuredContent)
|
|
var rows []map[string]any
|
|
require.NoError(t, json.Unmarshal(rb, &rows))
|
|
require.Len(t, rows, 1, "must filter out non-owned server")
|
|
require.EqualValues(t, 7, rows[0]["id"])
|
|
}
|
|
|
|
func TestServerList_ServerWhitelistFurtherFiltering(t *testing.T) {
|
|
cleanup, uid := setupMCPTest(t)
|
|
defer cleanup()
|
|
|
|
srv2 := &model.Server{}
|
|
srv2.ID = 8
|
|
srv2.Name = "beta"
|
|
srv2.SetUserID(uid)
|
|
singleton.ServerShared.InsertForTest(srv2)
|
|
|
|
tok, _ := mkToken(t, uid, []string{model.ScopeServerRead}, []uint64{8})
|
|
c, w := mcpCallCtx(t, tok, uid, jsonRPCRequest{
|
|
JSONRPC: "2.0", ID: json.RawMessage("1"), Method: "tools/call",
|
|
Params: jsonObj(t, toolCallParams{Name: "server.list", Arguments: json.RawMessage("{}")}),
|
|
})
|
|
mcpEndpoint(c)
|
|
_, tcr := decodeRPC(w)
|
|
require.False(t, tcr.IsError)
|
|
rb, _ := json.Marshal(tcr.StructuredContent)
|
|
var rows []map[string]any
|
|
require.NoError(t, json.Unmarshal(rb, &rows))
|
|
require.Len(t, rows, 1)
|
|
require.EqualValues(t, 8, rows[0]["id"])
|
|
}
|
|
|
|
func TestServerList_OnlineOnlyFilter(t *testing.T) {
|
|
cleanup, uid := setupMCPTest(t)
|
|
defer cleanup()
|
|
|
|
srv, _ := singleton.ServerShared.Get(7)
|
|
require.NotNil(t, srv)
|
|
srv.LastActive = time.Now()
|
|
|
|
tok, _ := mkToken(t, uid, []string{model.ScopeServerRead}, nil)
|
|
c, w := mcpCallCtx(t, tok, uid, jsonRPCRequest{
|
|
JSONRPC: "2.0", ID: json.RawMessage("1"), Method: "tools/call",
|
|
Params: jsonObj(t, toolCallParams{Name: "server.list", Arguments: jsonRaw(map[string]any{"online_only": true})}),
|
|
})
|
|
mcpEndpoint(c)
|
|
_, tcr := decodeRPC(w)
|
|
require.False(t, tcr.IsError)
|
|
rb, _ := json.Marshal(tcr.StructuredContent)
|
|
var rows []map[string]any
|
|
require.NoError(t, json.Unmarshal(rb, &rows))
|
|
require.Len(t, rows, 1)
|
|
}
|
|
|
|
func TestServerGet_RequiresServerID(t *testing.T) {
|
|
cleanup, uid := setupMCPTest(t)
|
|
defer cleanup()
|
|
tok, _ := mkToken(t, uid, []string{model.ScopeServerRead}, nil)
|
|
c, w := mcpCallCtx(t, tok, uid, jsonRPCRequest{
|
|
JSONRPC: "2.0", ID: json.RawMessage("1"), Method: "tools/call",
|
|
Params: jsonObj(t, toolCallParams{Name: "server.get", Arguments: json.RawMessage("{}")}),
|
|
})
|
|
mcpEndpoint(c)
|
|
_, tcr := decodeRPC(w)
|
|
require.True(t, tcr.IsError)
|
|
require.Contains(t, tcr.Content[0].Text, "server_id required")
|
|
}
|
|
|
|
func TestServerExec_ScopeMissing(t *testing.T) {
|
|
cleanup, uid := setupMCPTest(t)
|
|
defer cleanup()
|
|
tok, _ := mkToken(t, uid, []string{model.ScopeServerRead}, nil)
|
|
c, w := mcpCallCtx(t, tok, uid, jsonRPCRequest{
|
|
JSONRPC: "2.0", ID: json.RawMessage("1"), Method: "tools/call",
|
|
Params: jsonObj(t, toolCallParams{Name: "server.exec", Arguments: jsonRaw(map[string]any{"server_id": 7, "cmd": "echo"})}),
|
|
})
|
|
mcpEndpoint(c)
|
|
_, tcr := decodeRPC(w)
|
|
require.True(t, tcr.IsError)
|
|
require.Contains(t, tcr.Content[0].Text, "nezha:server:exec")
|
|
}
|