Files
nezha_domains/cmd/dashboard/controller/service_cache_key_test.go
T
naibaandcloudcode ab25662ddd feat(auth): add PAT auth, scoped REST/MCP access, CSRF, and tenant isolation
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.

Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.

Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.

Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.

Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
2026-05-30 15:56:44 +00:00

59 lines
1.6 KiB
Go

package controller
import (
"net/http/httptest"
"testing"
"github.com/gin-gonic/gin"
"github.com/nezhahq/nezha/model"
)
func newCacheKeyCtx(t *testing.T, user *model.User, tok *model.APIToken) *gin.Context {
t.Helper()
gin.SetMode(gin.TestMode)
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
c.Request = httptest.NewRequest("GET", "/api/v1/service", nil)
if user != nil {
c.Set(model.CtxKeyAuthorizedUser, user)
}
if tok != nil {
c.Set(model.CtxKeyAPIToken, tok)
c.Set(apiTokenCtxKey, tok)
}
return c
}
func TestServiceResponseCacheKey_DistinguishesPATsWithDifferentServerWhitelist(t *testing.T) {
user := &model.User{Common: model.Common{ID: 100}, Role: model.RoleMember}
tokA := &model.APIToken{ID: 1, UserID: 100}
tokA.SetServerIDs([]uint64{7})
tokB := &model.APIToken{ID: 2, UserID: 100}
tokB.SetServerIDs([]uint64{8})
keyA := serviceResponseCacheKey(newCacheKeyCtx(t, user, tokA))
keyB := serviceResponseCacheKey(newCacheKeyCtx(t, user, tokB))
if keyA == keyB {
t.Fatalf("singleflight key must differ across PATs with disjoint server_ids; got %q for both",
keyA)
}
}
func TestServiceResponseCacheKey_DistinguishesPATFromJWT(t *testing.T) {
user := &model.User{Common: model.Common{ID: 100}, Role: model.RoleMember}
tok := &model.APIToken{ID: 1, UserID: 100}
tok.SetServerIDs([]uint64{7})
keyPAT := serviceResponseCacheKey(newCacheKeyCtx(t, user, tok))
keyJWT := serviceResponseCacheKey(newCacheKeyCtx(t, user, nil))
if keyPAT == keyJWT {
t.Fatalf("PAT-shaped key must not collide with the JWT-shaped key; got %q for both", keyPAT)
}
}