mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 17:50:12 +00:00
naibaandcloudcode
ab25662ddd
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.
Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.
Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.
Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.
Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
67 lines
2.7 KiB
Go
67 lines
2.7 KiB
Go
package controller
|
|
|
|
import (
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
|
|
"github.com/nezhahq/nezha/model"
|
|
"github.com/nezhahq/nezha/pkg/i18n"
|
|
"github.com/nezhahq/nezha/service/singleton"
|
|
)
|
|
|
|
func ensureLocalizerForServiceTest(t *testing.T) {
|
|
t.Helper()
|
|
if singleton.Localizer == nil {
|
|
singleton.Localizer = i18n.NewLocalizer("en_US", "nezha", "translations", i18n.Translations)
|
|
}
|
|
}
|
|
|
|
// M13 regression: checkServiceSkipServerPermission must treat SkipServers
|
|
// as a typed map[uint64]bool where only `true` entries actually skip
|
|
// at runtime (DispatchTask only consults true keys). Entries with value
|
|
// false carry no dispatch meaning, so requiring HasPermission on them
|
|
// rejects perfectly legitimate updates from members whose PAT does not
|
|
// own the no-op `{2: false}` server.
|
|
func TestCheckServiceSkipServerPermission_IgnoresFalseEntries(t *testing.T) {
|
|
ensureLocalizerForServiceTest(t)
|
|
saved := singleton.ServerShared
|
|
t.Cleanup(func() { singleton.ServerShared = saved })
|
|
sc := singleton.NewEmptyServerClassForTest()
|
|
sc.InsertForTest(&model.Server{Common: model.Common{ID: 1, UserID: 100}})
|
|
sc.InsertForTest(&model.Server{Common: model.Common{ID: 2, UserID: 999}})
|
|
singleton.ServerShared = sc
|
|
|
|
ctx, _ := gin.CreateTestContext(httptest.NewRecorder())
|
|
ctx.Set(model.CtxKeyAuthorizedUser, &model.User{Common: model.Common{ID: 100}, Role: model.RoleMember})
|
|
|
|
skip := map[uint64]bool{
|
|
1: true, // member owns it — legal allow-list entry
|
|
2: false, // no-op entry; member doesn't own server 2 but it's not actually skipped
|
|
}
|
|
if err := checkServiceSkipServerPermission(ctx, model.ServiceCoverIgnoreAll, skip, 100); err != nil {
|
|
t.Fatalf("`{2: false}` must NOT trigger permission denied — it has no runtime dispatch effect, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestCheckServiceSkipServerPermission_RejectsForeignTrueEntries(t *testing.T) {
|
|
ensureLocalizerForServiceTest(t)
|
|
saved := singleton.ServerShared
|
|
t.Cleanup(func() { singleton.ServerShared = saved })
|
|
sc := singleton.NewEmptyServerClassForTest()
|
|
sc.InsertForTest(&model.Server{Common: model.Common{ID: 1, UserID: 100}})
|
|
sc.InsertForTest(&model.Server{Common: model.Common{ID: 2, UserID: 999}})
|
|
singleton.ServerShared = sc
|
|
|
|
ctx, _ := gin.CreateTestContext(httptest.NewRecorder())
|
|
ctx.Set(model.CtxKeyAuthorizedUser, &model.User{Common: model.Common{ID: 100}, Role: model.RoleMember})
|
|
|
|
skip := map[uint64]bool{
|
|
2: true, // member doesn't own server 2 — true entry IS the allow-list, must reject
|
|
}
|
|
if err := checkServiceSkipServerPermission(ctx, model.ServiceCoverIgnoreAll, skip, 100); err == nil {
|
|
t.Fatal("true entry pointing at foreign-owned server must still be rejected — pre-existing safety invariant")
|
|
}
|
|
}
|