fix: enhance cipher login URI handling and import format support

This commit is contained in:
shuaiplus
2026-06-06 22:43:16 +08:00
parent 1ee7b0f31b
commit cda654e1c3
4 changed files with 43 additions and 22 deletions
+33 -19
View File
@@ -819,13 +819,15 @@ async function repairCipherLoginUris(
continue;
}
let clearUri = String(entry.decUri || '').trim();
if (!clearUri || looksLikeCipherString(clearUri)) {
try {
clearUri = (await decryptStr(rawUri, enc, mac)).trim();
} catch {
uris.push({ ...encryptedEntry });
continue;
let clearUri = '';
let rawUriUsesCurrentKey = false;
try {
clearUri = (await decryptStr(rawUri, enc, mac)).trim();
rawUriUsesCurrentKey = !!clearUri;
} catch {
const fallbackUri = String(entry.decUri || '').trim();
if (fallbackUri && !looksLikeCipherString(fallbackUri)) {
clearUri = fallbackUri;
}
}
@@ -845,15 +847,20 @@ async function repairCipherLoginUris(
}
}
if (currentChecksumOk) {
if (currentChecksumOk && rawUriUsesCurrentKey) {
uris.push({ ...encryptedEntry });
continue;
}
const repairedUri = rawUriUsesCurrentKey ? rawUri : await encryptTextValue(clearUri, enc, mac);
const repairedChecksum = currentChecksumOk
? rawChecksum
: await encryptTextValue(expectedChecksum, enc, mac);
uris.push({
...encryptedEntry,
uri: rawUri,
uriChecksum: await encryptTextValue(expectedChecksum, enc, mac),
uri: repairedUri || rawUri,
uriChecksum: repairedChecksum,
match: typeof entry.match === 'number' && Number.isFinite(entry.match) ? entry.match : null,
});
changed = true;
@@ -889,15 +896,22 @@ export async function repairCipherUriChecksums(
let repaired = 0;
for (const cipher of ciphers) {
if (!cipher?.id || cipher.type !== 1 || !looksLikeCipherString(cipher.key) || !cipher.login || !Array.isArray(cipher.login.uris)) continue;
let itemKey: Uint8Array;
try {
itemKey = await decryptBw(String(cipher.key).trim(), userEnc, userMac);
} catch {
continue;
if (!cipher?.id || cipher.type !== 1 || !cipher.login || !Array.isArray(cipher.login.uris)) continue;
let keys: { enc: Uint8Array; mac: Uint8Array; key: string | null } = {
enc: userEnc,
mac: userMac,
key: null,
};
if (looksLikeCipherString(cipher.key)) {
let itemKey: Uint8Array;
try {
itemKey = await decryptBw(String(cipher.key).trim(), userEnc, userMac);
} catch {
continue;
}
if (itemKey.length < 64) continue;
keys = { enc: itemKey.slice(0, 32), mac: itemKey.slice(32, 64), key: String(cipher.key).trim() };
}
if (itemKey.length < 64) continue;
const keys = { enc: itemKey.slice(0, 32), mac: itemKey.slice(32, 64), key: String(cipher.key).trim() };
const repair = await repairCipherLoginUris(cipher, keys.enc, keys.mac);
if (!repair.changed) continue;
@@ -912,9 +926,9 @@ export async function repairCipherUriChecksums(
fields: Array.isArray(cipher.fields)
? cipher.fields.map(({ decName: _decName, decValue: _decValue, ...field }) => field)
: null,
key: keys.key,
lastKnownRevisionDate: cipher.revisionDate ?? null,
};
if (keys.key) payload.key = keys.key;
const resp = await authedFetch(`/api/ciphers/${encodeURIComponent(cipher.id)}`, {
method: 'PUT',
+3
View File
@@ -189,12 +189,15 @@ function mapCipherEncrypted(cipher: Cipher): Record<string, unknown> {
const login = cipher.login;
out.login = login
? {
...cloneValue(login),
username: login.username ?? null,
password: login.password ?? null,
totp: login.totp ?? null,
uris: Array.isArray(login.uris)
? login.uris.map((uri) => ({
...cloneValue(uri),
uri: uri?.uri ?? null,
uriChecksum: uri?.uriChecksum ?? null,
match: (uri as { match?: unknown })?.match ?? null,
}))
: [],
@@ -7,6 +7,7 @@ export interface BitwardenFolderInput {
export interface BitwardenUriInput {
uri?: string | null;
uriChecksum?: string | null;
match?: number | null;
}