Buriburizaemon/nezha_domains
1
0
Fork 0
mirror of https://github.com/Buriburizaem0n/nezha_domains.git synced 2026-09-19 09:40:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(agentcompat): cover CRLF workflow mutations

Browse Source 
Co-authored-by: naiba/CloudCode <hi+cloudcode@nai.ba>
This commit is contained in:
naiba
2026-07-20 17:06:14 +00:00
co-authored by naiba/CloudCode
parent 153dfeb569
commit 24c7a898cf
1 changed files with 36 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration/agentcompat/internal/workflowpolicy/required_aggregator_test.go
+36 -12
View File
@@ -24,6 +24,14 @@ func TestPolicy_RejectsMissingRequiredDependency(t *testing.T) {
}
func TestPolicy_RejectsInvalidRequiredAggregator(t *testing.T) {
workflowData := readNezhaQualityWorkflow(t)
workflowVariants := []struct {
name string
data []byte
}{
{name: "LF", data: workflowData},
{name: "CRLF", data: []byte(strings.ReplaceAll(string(workflowData), "\n", "\r\n"))},
}
tests := []struct {
name string
currentText string
@@ -80,24 +88,40 @@ func TestPolicy_RejectsInvalidRequiredAggregator(t *testing.T) {
}, "\n "),
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
// Given
data := readNezhaQualityWorkflow(t)
invalidWorkflow := strings.Replace(string(data), test.currentText, test.invalidText, 1)
require.NotEqual(t, string(data), invalidWorkflow, "workflow mutation must match current content")
for _, variant := range workflowVariants {
t.Run(variant.name, func(t *testing.T) {
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
// Given
invalidWorkflow := mutateWorkflow(t, variant.data, test.currentText, test.invalidText)
// When
err := workflowpolicy.Verify([]byte(invalidWorkflow), workflowpolicy.RepositoryNezha)
// When
err := workflowpolicy.Verify([]byte(invalidWorkflow), workflowpolicy.RepositoryNezha)
// Then
var policyError *workflowpolicy.PolicyError
require.ErrorAs(t, err, &policyError)
require.True(t, policyError.Has(workflowpolicy.RuleWorkflowStructure))
// Then
var policyError *workflowpolicy.PolicyError
require.ErrorAs(t, err, &policyError)
require.True(t, policyError.Has(workflowpolicy.RuleWorkflowStructure))
})
}
})
}
}
func mutateWorkflow(t *testing.T, data []byte, currentText, invalidText string) string {
t.Helper()
workflow := string(data)
lineEnding := "\n"
if strings.Contains(workflow, "\r\n") {
// Windows checkouts preserve CRLF, so multiline mutation snippets must use the source line ending.
lineEnding = "\r\n"
}
currentText = strings.ReplaceAll(currentText, "\n", lineEnding)
invalidText = strings.ReplaceAll(invalidText, "\n", lineEnding)
require.Equal(t, 1, strings.Count(workflow, currentText), "workflow mutation must match current content exactly once")
return strings.Replace(workflow, currentText, invalidText, 1)
}
func TestPolicy_RejectsMissingRequiredAggregator(t *testing.T) {
assertFixtureRejected(t, rejected("missing-required-aggregator.yml", workflowpolicy.RuleWorkflowStructure, "aggregator is missing"))
}