mirror of
https://github.com/Buriburizaem0n/nezha_domains.git
synced 2026-09-19 17:50:12 +00:00
naibaandcloudcode
e8dabf5bc6
Introduce Personal Access Tokens (nzp_*) as a stateless auth path alongside
JWT, gated per-endpoint by a scope middleware (nezha:{resource}:{verb}) with
fail-closed empty-scope defaults and a server-id whitelist. Self-management
endpoints (profile, api-tokens, oauth2 bind, refresh-token) explicitly reject
PATs to block privilege-escalation chains. A revoke registry tears down active
long-lived connections (terminal, fm, ws, transfer, mcp) the moment a PAT is
deleted, with a tombstone closing the revoke->register race.
Add an MCP endpoint that proxies tool calls (exec, fs read/write/delete,
transfer) to agents over gRPC, guarded by origin/DNS-rebinding checks, a
per-token rate limiter, audit logging, and a kill switch. Serialize all
sends through the IOStream wrapper to honour grpc-go's concurrency contract.
Add CSRF double-submit protection on unsafe cookie-authenticated methods,
exempting authenticated PAT requests by context identity (not a forgeable
Authorization header). Apply visibility/whitelist filtering consistently
across list, get-by-id, and mutate paths to enforce tenant isolation.
Migrate legacy mcp:* scopes: rewrite read/exec to nezha:* equivalents and
drop dangerous write/delete/wildcard grants.
Co-authored-by: cloudcode <cloudcode@users.noreply.github.com>
64 lines
1.9 KiB
Go
64 lines
1.9 KiB
Go
package controller
|
|
|
|
import (
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
|
|
"github.com/nezhahq/nezha/model"
|
|
)
|
|
|
|
// H3 regression: file-manager sessions read/write/delete files, but the route
|
|
// only requires nezha:server:write. PAT scopes are advertised as fine-grained
|
|
// (read / write / delete / exec); allowing a write-only PAT to open an FM
|
|
// session that can list & remove files silently widens the scope.
|
|
func TestRestScopeAllOf_RequiresEveryScope(t *testing.T) {
|
|
mw := restScopeAllOf(model.ScopeServerRead, model.ScopeServerWrite, model.ScopeServerDelete)
|
|
|
|
t.Run("rejects_token_missing_delete", func(t *testing.T) {
|
|
w := httptest.NewRecorder()
|
|
c, _ := gin.CreateTestContext(w)
|
|
tok := &model.APIToken{ScopesCSV: "nezha:server:read,nezha:server:write"}
|
|
c.Set(apiTokenCtxKey, tok)
|
|
c.Set(model.CtxKeyAPIToken, tok)
|
|
mw(c)
|
|
if !c.IsAborted() || w.Code != 403 {
|
|
t.Fatalf("missing delete scope must abort with 403, got aborted=%v code=%d", c.IsAborted(), w.Code)
|
|
}
|
|
})
|
|
|
|
t.Run("accepts_token_with_all_scopes", func(t *testing.T) {
|
|
w := httptest.NewRecorder()
|
|
c, _ := gin.CreateTestContext(w)
|
|
tok := &model.APIToken{ScopesCSV: "nezha:server:read,nezha:server:write,nezha:server:delete"}
|
|
c.Set(apiTokenCtxKey, tok)
|
|
c.Set(model.CtxKeyAPIToken, tok)
|
|
mw(c)
|
|
if c.IsAborted() {
|
|
t.Fatal("token carrying all required scopes must pass")
|
|
}
|
|
})
|
|
|
|
t.Run("jwt_callers_skip_check", func(t *testing.T) {
|
|
w := httptest.NewRecorder()
|
|
c, _ := gin.CreateTestContext(w)
|
|
mw(c)
|
|
if c.IsAborted() {
|
|
t.Fatal("JWT (no PAT) must pass through restScopeAllOf unchanged")
|
|
}
|
|
})
|
|
|
|
t.Run("wildcard_resource_scope_satisfies_all", func(t *testing.T) {
|
|
w := httptest.NewRecorder()
|
|
c, _ := gin.CreateTestContext(w)
|
|
tok := &model.APIToken{ScopesCSV: "nezha:server:*"}
|
|
c.Set(apiTokenCtxKey, tok)
|
|
c.Set(model.CtxKeyAPIToken, tok)
|
|
mw(c)
|
|
if c.IsAborted() {
|
|
t.Fatal("nezha:server:* must satisfy server:read+write+delete")
|
|
}
|
|
})
|
|
}
|